Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to adapt to R2 cluster configurations #11

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Changes to adapt to R2 cluster configurations #11

merged 5 commits into from
Dec 19, 2023

Conversation

josephthaliath
Copy link
Contributor

No description provided.

@electrocucaracha electrocucaracha mentioned this pull request Dec 18, 2023
Merged
@electrocucaracha
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Dec 18, 2023
johnbelamaric
johnbelamaric reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just the README needs to be updated to reference the nephio-project org.

After this merges, I can create the tags.

workloads/oai/README.md Outdated Show resolved Hide resolved
workloads/oai/pkg-example-cucp-bp/apply-replacements-owner.yaml
@@ -24,20 +24,6 @@ replacements:
options:
delimiter: '-'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found apply-replacements with delimiters to be very fragile, I would avoid them if possible (maybe a future update, or eventually I would hope these become unnecessary with the implementation of CEL for function inputs)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @johnbelamaric , we will consider it in the next updates.

@nephio-prow nephio-prow bot removed the lgtm label Dec 19, 2023
@johnbelamaric
Copy link
Member

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Dec 19, 2023
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, josephthaliath

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Dec 19, 2023
@nephio-prow nephio-prow bot merged commit fff1db3 into nephio-project:main Dec 19, 2023
2 checks passed
@johnbelamaric
Copy link
Member

Tags are done:

[hi on] jbelamaric@jbelamaric:~/proj/gh/nephio-project/catalog$ git tag workloads/oai/oai-ran-operator/v1
[hi on] jbelamaric@jbelamaric:~/proj/gh/nephio-project/catalog$ git tag workloads/oai/pkg-example-cucp-bp/v1
[hi on] jbelamaric@jbelamaric:~/proj/gh/nephio-project/catalog$ git tag workloads/oai/pkg-example-cuup-bp/v1
[hi on] jbelamaric@jbelamaric:~/proj/gh/nephio-project/catalog$ git tag workloads/oai/pkg-example-du-bp/v1
[hi on] jbelamaric@jbelamaric:~/proj/gh/nephio-project/catalog$ git tag workloads/oai/pkg-example-ue-bp/v1
[hi on] jbelamaric@jbelamaric:~/proj/gh/nephio-project/catalog$ git tag
distros/gcp/cc-rootsync/v1
distros/gcp/nephio-mgmt/v1
infra/gcp/cc-cluster-gke-std-csr-cs/v1
infra/gcp/cc-repo-csr/v1
infra/gcp/nephio-blueprint-repo/v1
infra/gcp/nephio-workload-cluster-gke/v1
workloads/oai/oai-ran-operator/v1
workloads/oai/pkg-example-cucp-bp/v1
workloads/oai/pkg-example-cuup-bp/v1
workloads/oai/pkg-example-du-bp/v1
workloads/oai/pkg-example-ue-bp/v1
[hi on] jbelamaric@jbelamaric:~/proj/gh/nephio-project/catalog$ git push --tags
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:nephio-project/catalog.git
 * [new tag]         workloads/oai/oai-ran-operator/v1 -> workloads/oai/oai-ran-operator/v1
 * [new tag]         workloads/oai/pkg-example-cucp-bp/v1 -> workloads/oai/pkg-example-cucp-bp/v1
 * [new tag]         workloads/oai/pkg-example-cuup-bp/v1 -> workloads/oai/pkg-example-cuup-bp/v1
 * [new tag]         workloads/oai/pkg-example-du-bp/v1 -> workloads/oai/pkg-example-du-bp/v1
 * [new tag]         workloads/oai/pkg-example-ue-bp/v1 -> workloads/oai/pkg-example-ue-bp/v1
[hi on] jbelamaric@jbelamaric:~/proj/gh/nephio-project/catalog$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric johnbelamaric left review comments

@henderiw henderiw Awaiting requested review from henderiw

@s3wong s3wong Awaiting requested review from s3wong

@arora-sagar arora-sagar Awaiting requested review from arora-sagar

Assignees

@electrocucaracha electrocucaracha

@johnbelamaric johnbelamaric

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephthaliath @electrocucaracha @johnbelamaric